dahjah/Lime3DS
1
0
Fork 0
mirror of https://github.com/Lime3DS/Lime3DS.git synced 2025-12-16 12:08:49 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix off-by-one error in savestates that could cause crashes (#977)

Browse Source
This commit is contained in:
PabloMK7 2025-04-24 19:04:59 +02:00 committed by GitHub
parent 939a6e0f7a
commit 493f59cef5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/citra_qt/citra_qt.cpp
View File

@ -1619,6 +1619,9 @@ void GMainWindow::UpdateSaveStates() {
} }
} }
for (const auto& savestate : savestates) { for (const auto& savestate : savestates) {
if (savestate.slot >= Core::SaveStateSlotCount) {
continue;
}
const bool display_name = const bool display_name =
savestate.status == Core::SaveStateInfo::ValidationStatus::RevisionDismatch && savestate.status == Core::SaveStateInfo::ValidationStatus::RevisionDismatch &&
!savestate.build_name.empty(); !savestate.build_name.empty();
@ -1659,7 +1662,7 @@ void GMainWindow::UpdateSaveStates() {
for (u32 i = 1; i < Core::SaveStateSlotCount; ++i) { for (u32 i = 1; i < Core::SaveStateSlotCount; ++i) {
if (!actions_load_state[i]->isEnabled()) { if (!actions_load_state[i]->isEnabled()) {
// Prefer empty slot // Prefer empty slot
oldest_slot = i + 1; oldest_slot = i;
oldest_slot_time = 0; oldest_slot_time = 0;
break; break;
} }