dahjah/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-12-23 06:57:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
44,506 Commits 12 Branches 18 Tags 4.3 GiB
57d7485ea6
Commit Graph

4206 Commits

Author SHA1 Message Date
Dentomologist
8a28b95480 IOFile: Require trivially copyable types 
Require ReadArray and WriteArray to be called with a trivially copyable
type.

ReadArray and WriteArray call std::fread and std::fwrite respectively.
These functions trigger undefined behavior when the objects are not
trivially copyable, so this adds that requirement to the callers.
 2025-07-14 11:55:24 -07:00
Joshua Vandaële
06882bd2dc
Fix various warnings 2025-07-12 12:47:30 +02:00
Sintendo
f2392e4048 Avoid map/set double lookups 
Fix some common anti-patterns with these data structures.

- You can dereference the iterator returned by `find` to access the
  underlying value directly, without an extra `operator[]`/`at`.
- Rather than checking for an element before insertion/deletion, you can
  just do the operation and if needed check the return value to
  determine if the insertion/deletion succeeded.
 2025-07-08 06:53:42 +02:00
Jordan Woyak
d55012f8d0
Merge pull request #13726 from hoogmin/cpp23_ranges_patch 
Common: Replace Contains and ContainsSubrange with C++23 std::ranges equivalents
 2025-07-07 21:05:28 -05:00
Tillmann Karras
fe6fd2279c WiiSaveBanner: fall back to $userdir/Load/WiiBanners 
Unlike custom banners which work as an override, this mechanism works as
a fallback. The use case is if you have games you don't really play but
want to keep around for testing purposes without filling up your NAND
with lots of saves. For ease of use, the directory structure is the same
but only title/$title_hi/$title_lo/data/banner.bin files are
relevant.
 2025-07-04 23:15:50 +01:00
TryTwo
fe121e4c6e PPCSymbolDB: Move loading map on boot logic from boot.cpp into PPCSymbolDB, as it will be needing a mutex. 
Cleanup loading code and reduce amount of signals.

On boot. allow previously loaded map to be kept, if its filename matches. Useful for restarting a game with a large symbol map.
 2025-06-25 12:01:16 -07:00
JMC47
19f3b7e61f
Merge pull request #13691 from TryTwo/PR_Notes 
Debugger Add note-type symbols .
 2025-06-22 01:05:42 -04:00
TryTwo
040d9a4336 Debugger symbols: Add new symbol type: Notes.. Notes are for naming single instructions, or small groups of instructions. 
Notes are separate from function symbols, and can be searched separately.
Unlike functions, notes of different length can overlap each other.
In the instruction window, a note will always display over the function symbol.
 2025-06-19 17:55:35 -07:00
Jordan Woyak
3a94289ad6
Merge pull request #13744 from JoshuaVandaele/windows-specific-getdevicename 
Host: Implement a Windows-only implementation of `GetDeviceNameFromVIDPID`
 2025-06-15 15:44:31 -05:00
Dr. Dystopia
ca8f9b672b Source: Remove redundant lambda parameter lists 2025-06-14 10:19:31 +02:00
Joshua Vandaële
d93245cc7a
Host: Implement a Windows-only implementation of GetDeviceNameFromVIDPID 2025-06-13 17:46:53 +02:00
Tilka
19fbbf0dba
Merge pull request #13727 from JoshuaVandaele/fmt-11.2.0-localtime-deprec 
fmt: Replace deprecated `fmt::localtime` usage with `Common::LocalTime`
 2025-06-08 04:04:37 +01:00
Jordan Woyak
65f3ba70f5
Merge pull request #13522 from tygyh/Enforce-overriding-destructor-style-Core&UnitTests 
Core & UnitTests: Make overriding explicit and remove redundant virtual specifiers on overriding destructors
 2025-06-07 17:55:14 -05:00
iwubcode
7d59c2743d Common: Add class 'FilesystemWatcher' that is used to watch paths and receive callbacks about filesystem level events for anything under that path 2025-06-06 23:03:02 -05:00
Javier Martinez
d766c527c7 Common: Replace Contains and ContainsSubrange with C++23 std::ranges equivalents 
Common: Use feature macros for better compatibility

Common/Contains.h: fix linting issue

Common/Contains.h: Add C++23 TODO

Common/Contains.h: Fix comment lint issue.
 2025-06-05 19:18:08 -04:00
JMC47
8def02072b
Merge pull request #13379 from JoshuaVandaele/system-ng 
Use minizip-ng in non-compatibility mode
 2025-06-04 15:21:05 -04:00
Joshua Vandaële
4b65cc9a4c
fmt: Replace deprecated fmt::localtime usage with Common::LocalTime 2025-06-04 13:32:12 +02:00
Jordan Woyak
31d0756808 Config: Make s_callbacks_lock recursive to fix hardcore mode deadlock. 2025-05-30 17:33:01 -05:00
JosJuice
18a78a9bab
Merge pull request #13647 from jordan-woyak/sha1-avoid-memcpy 
Crypto/SHA1: Re-add memcpy avoiding optimization to BlockContext::Update.
 2025-05-25 12:40:43 +02:00
Joshua Vandaële
2ed5f16600
minizip-ng: Stop using compatibility mode 2025-05-22 12:51:55 +02:00
Jordan Woyak
9ba71448cc WorkQueueThread: Fix Cancel() race with internal command queue. 2025-05-20 21:51:25 -05:00
Jordan Woyak
bb77d61967 Crypto/SHA1: Re-add memcpy avoiding optimization to BlockContext::Update. 2025-05-09 20:59:17 -05:00
JMC47
463bd86145
Merge pull request #13641 from jordan-woyak/sha1-fix 
Crypto/SHA1: Fix past-the-last-element std::array access and modernize code.
 2025-05-09 18:56:20 -04:00
JMC47
7113bafd94
Merge pull request #13586 from Tilka/spr_disasm 
GekkoDisassembler: standardize SPR names and add missing ones
 2025-05-09 18:55:53 -04:00
Jordan Woyak
a9ab0e979e Crypto/SHA1: Fix past-the-last-element std::array access and modernize code. 2025-05-08 03:03:59 -05:00
Jordan Woyak
845fecff22 Common/BitField: Make deleted functions public. 2025-05-05 19:34:35 -05:00
Jordan Woyak
2dc975fa92 Common: Replace enable_if with concepts and other minor modernizations. 2025-05-05 19:34:24 -05:00
Admiral H. Curtiss
d2db9d9590
Merge pull request #13608 from jordan-woyak/async-work-thread 
Common: Add AsyncWorkThread.
 2025-05-04 18:45:14 +02:00
Admiral H. Curtiss
2a3580fda5
Merge pull request #13482 from jordan-woyak/string-util-concepts 
StringUtil: Use concepts instead of enable_if.
 2025-05-04 17:47:37 +02:00
Admiral H. Curtiss
380a9291ad
Merge pull request #13602 from jordan-woyak/move-only-function 
Common: Add MoveOnlyFunction.
 2025-05-04 17:28:06 +02:00
Jordan Woyak
5a80105555 Common and VideoCommon: Change texture data from std::vector to Common::UniqueBuffer. 2025-05-03 18:32:30 -05:00
JosJuice
c8be819711 LogManager: Stop using manual memory management 
This fixes a memory leak that would occur when the Android frontend
calls LogManager::Init more than once in order to reload settings.

Note that the log window listener is now owned by LogManager instead of
by the frontend, making it consistent with the other log listeners.
 2025-05-02 21:14:32 +02:00
JosJuice
b566e81644
Merge pull request #13596 from JosJuice/config-callback-locking 
Config: Add locking for config changed callbacks
 2025-05-02 08:49:22 +02:00
Jordan Woyak
be4b0af971 Common: Add AsyncWorkThread. 2025-05-01 22:54:40 -05:00
Jordan Woyak
20874124c2 StringUtil: Use concepts instead of enable_if. 2025-05-01 16:30:37 -05:00
Dr. Dystopia
f240e20e3f Make overriding explicit and remove redundant virtual specifiers on overriding destructors - Core & UnitTests 2025-05-01 15:00:37 +02:00
Admiral H. Curtiss
2e20e24136
Merge pull request #13587 from jordan-woyak/manual-value 
Common: Move some duplicate container element construction logic into a ManuallyConstructedValue template.
 2025-04-30 23:45:33 +02:00
Jordan Woyak
4899913446 Common: Move some duplicate container element construction logic into a ManuallyConstructedValue template. 2025-04-30 14:56:07 -05:00
Jordan Woyak
a149b9d62d WorkQueueThread: Cleanups. Implement in terms of WaitableSPSCQueue. Add single producer WorkQueueThreadSP. 2025-04-30 14:31:51 -05:00
OatmealDome
0b0151770a
Merge pull request #13436 from JoshuaVandaele/clang-format-19 
Update clang-format to version 19
 2025-04-30 01:17:31 -04:00
Jordan Woyak
e403dee3da Common: Add MoveOnlyFunction. 2025-04-27 20:07:13 -05:00
JosJuice
f060baa257 Config: Add locking for config changed callbacks 
Different threads are adding and calling callbacks, so this should have
some locking. This is both to ensure thread safety when accessing
`s_callbacks` and to ensure that there won't be situations where a
callback gets called after it's removed.

`s_callback_guards` is also accessed from multiple threads and has
therefore been made atomic.
 2025-04-26 12:56:37 +02:00
Dentomologist
3a883f28d6 Config: Add [[nodiscard]] to AddConfigChangedCallback 
Require callers of Config::AddConfigChangedCallback and
CPUThreadConfigCallback::AddConfigChangedCallback to handle the returned
ConfigChangedCallbackIDs to hopefully prevent future issues with
callbacks getting called after their associated objects have been
destroyed.
 2025-04-25 16:04:12 -07:00
Tilka
805307f432
Merge pull request #13451 from vyuuui/numeric_labels 
Add numeric label support to assembler
 2025-04-25 01:56:43 +01:00
Tilka
50026ab795
Merge pull request #13497 from hoogmin/modernize_fs_path 
Core/Common/FileUtil.cpp: Use std path utility for automatic path separator handling.
 2025-04-25 01:38:35 +01:00
Tillmann Karras
4d9dc1e1cd GekkoDisassembler: standardize SPR names and add missing ones 2025-04-25 00:24:12 +01:00
Joshua Vandaële
bf554edfe0
linter: Add and apply new formatting rules 
New rules:
`InsertNewlineAtEOF: true`
`RemoveSemicolon: true`
`RequiresClausePosition: WithPreceding`
 2025-04-23 11:19:57 +02:00
Joshua Vandaële
2c54ee94c1
linter: Apply clang-format 19.1 formatting 
find ./Source/ -name '*.cpp' -o -name '*.h' | xargs clang-format-19 -i
 2025-04-23 11:19:20 +02:00
Jordan Woyak
af960651e8 Common: SPSCQueue cleanups and improvements. 2025-04-22 23:49:32 -05:00
Jordan Woyak
ac76deaef0
Merge pull request #13529 from jordan-woyak/StateBuffer 
Core/State: Avoid unnecessarily value-initializing large buffers.
 2025-04-22 16:30:51 -05:00
OatmealDome
da84a9f605
Merge pull request #13477 from OatmealDome/macos-11 
CMakeLists: Bump minimum macOS to 11.0
 2025-04-22 17:27:12 -04:00
JosJuice
e468e2359a IOS: Only have one USBScanner 
Some games open two USB interfaces, e.g. /dev/usb/oh0 and /dev/usb/hid.
This was causing us to run two scanning threads at once, using up more
CPU time for scanning than we need to.
 2025-04-21 21:57:49 +02:00
JosJuice
c0c180bdc2
Merge pull request #13467 from JosJuice/profiler-thread-safety 
Common: Make Profiler thread safe
 2025-04-21 20:19:47 +02:00
OatmealDome
7213cdd439 MemoryUtil: Remove availability checks for macOS 11 2025-04-21 00:24:58 -04:00
Tilka
0a52140145
Merge pull request #13549 from shuffle2/ucrtpatch 
remove ucrt compat patches
 2025-04-20 22:24:57 +01:00
Shawn Hoffman
2d1161150b remove ucrt compat patches 
Dolphin has not supported a version of windows where
these binaries exist for a while.
 2025-04-20 12:50:10 -07:00
Shawn Hoffman
5dd896a7d9 HttpRequest: remove some legacy code for windows < 8.1 2025-04-20 11:46:09 -07:00
Jordan Woyak
12dcd6c285 Common: Add UniqueBuffer and SharedBuffer templates. 2025-04-19 17:13:40 -05:00
Jordan Woyak
f78fa2e9f1 LinearDiskCache: Use make_unique_for_overwrite. 2025-04-19 17:13:40 -05:00
Jordan Woyak
cb20959679 Common/Timer: Change HANDLE to void* to avoid including Windows.h to fix cmake build. 2025-04-18 21:50:15 -05:00
OatmealDome
2af276d27e MemArenaDarwin: Initialize all address variables passed to vm_map 2025-04-16 00:50:54 -04:00
Javier Martinez
7ca8dc3767 Use std path utility for automatic path seperator handling. 
It was being done manually, which a TODO comment advised against.
Using generic_string() from std::filesystem::path solves this.

Fix encoding issue using generic_wstring instead.
 2025-04-08 16:54:11 -04:00
Jordan Woyak
e0e53f3235 Common/Timer: Use YieldProcessor on Windows. 2025-04-03 15:48:51 -05:00
Jordan Woyak
e5c8935acc Common: Create a PrecisionTimer class. 2025-04-03 15:48:51 -05:00
JosJuice
957265ba52 Common: Make Profiler thread safe 2025-03-29 15:05:02 +01:00
JMC47
1981f22228
Merge pull request #13433 from iwubcode/update_min_win10 
Update our minimum windows 10 version to 1903 and reinstate code that depends on it
 2025-03-25 18:30:15 -04:00
vyuuui
e34907025d Add numeric label support to assembler 2025-03-24 18:59:32 -07:00
JMC47
ad3650abfc
Merge pull request #13093 from mitaclaw/ranges-modernization-4-projection 
Ranges Algorithms Modernization - Projection
 2025-03-23 15:56:13 -04:00
Jordan Woyak
ba1bf6959e Config: Allow passing a DefaultState object to Set functions to delete keys. 2025-03-17 20:46:24 -05:00
OatmealDome
07cec796f4
Merge pull request #13417 from luzpaz/typo-source-core-common 
Core/Common: Fix typos
 2025-03-16 14:53:02 -04:00
iwubcode
c1dea828ab Common: use std::chrono for GetLocalTimeSinceJan1970 on Windows 
Co-authored-by: Shawn Hoffman <godisgovernment@gmail.com>
 2025-03-16 00:59:45 -05:00
iwubcode
373a1a5dc0 Update min win10 version from 1703/15063 to 1903/18362 
Co-authored-by: Shawn Hoffman <godisgovernment@gmail.com>
 2025-03-16 00:59:45 -05:00
JMC47
1bd3e79fda
Merge pull request #13378 from jordan-woyak/desired-ext-state 
WiimoteEmu: Clean up variant handling in DesiredExtensionState.
 2025-03-15 17:26:49 -04:00
JosJuice
e637a05707
Merge pull request #12866 from JosJuice/android-log-types-sorting 
Android: Replace log type names map with array
 2025-03-15 16:01:33 +01:00
JosJuice
8c7ab286f5
Merge pull request #13181 from tygyh/Replace-'reinterpret_cast' 
Replace 'reinterpret_cast' with 'static_cast'
 2025-03-15 15:31:38 +01:00
Luz Paz
1b47dbf519 Core/Common: Fix typos 
Found via `codespell -q 3 -S "./Externals,./Data/Sys/wiitdb-??.txt,*.po,*.pot" -L andf,asnd,bootup,brocken,bufferin,clen,collet,datas,delt,diety,extint,fpr,inout,inport,interm,nd,nin,ontop,pixelx,re-use,re-used,sav,stateman,strat,transer,wil`
 2025-03-11 19:48:45 -04:00
JMC47
9f43f59c9b
Merge pull request #13276 from JoshuaVandaele/sfml-3.0.0 
Migrate to SFML 3.0.0
 2025-03-10 15:03:36 -04:00
mitaclaw
258ec4f9cd Modernize std::lower_bound/upper_bound with ranges and projections 2025-03-09 13:26:38 -07:00
mitaclaw
8b9f92a0af Modernize std::sort with ranges and projections 
In PPCTables.cpp, the code is currently unused so I was unable to test it.

In CustomPipeline.cpp, a pointer to member function cannot be used due to 16.4.5.2.1 of the C++ Standard regarding "addressable functions". https://eel.is/c++draft/namespace.std#6

In Fs.cpp and DirectoryBlob.cpp, these examples used projections in a previous iteration of this commit, but no longer do. Still, they remain in this commit because the PR they would actually belong to is already merged.
 2025-03-09 13:26:38 -07:00
mitaclaw
62b2b939b5 Simplify std::find_if with std::ranges::find and projections 
In LabelMap.cpp, the code is currently unused so I was unable to test it.

In WiiUtils.cpp, the magic value `1u` was replaced by the constant value `DiscIO::PARTITION_UPDATE`.
 2025-03-09 13:26:35 -07:00
mitaclaw
1e5e9219cd Common: Create Range Projections For std::pair 2025-03-09 13:19:41 -07:00
Jordan Woyak
1d481a395a VariantUtil: Introduce WithVariantAlternative to dynamically construct and visit a variant alternative. 2025-02-25 17:22:59 -06:00
Joshua Vandaële
0a83783fae
Migrate to SFML>=3.0.0 2025-02-25 06:42:13 +01:00
JosJuice
0f83598493 Common: Make SD pack/unpack strings translatable 
Regression from adc5b81.
 2025-02-23 23:09:24 +01:00
Jordan Woyak
adc5b81c31 DolphinQt: Rename the pack/unpack SD Card buttons. 2025-02-12 13:30:48 -06:00
Admiral H. Curtiss
f1fe32c93b
Merge pull request #13254 from brad0/openbsd_aarch64 
ArmCPUDetect: Add OpenBSD support for elf_aux_info
 2025-02-02 18:12:03 +01:00
Jordan Woyak
9777e8e76b Common: Make SmallVector work with non-standard-layout types. 2025-01-26 13:03:39 -06:00
Brad Smith
a20f96b78c ArmCPUDetect: Add OpenBSD support for elf_aux_info 2025-01-22 22:58:00 -05:00
iwubcode
75425ced05 Common: add 'clear' function to SmallVector 2025-01-20 15:13:56 -06:00
OatmealDome
7ba56bc738
Merge pull request #13269 from OatmealDome/memarena-darwin 
MemArena: Add Darwin implementation
 2025-01-20 14:11:37 -05:00
Joshua Vandaële
fa442dc90b
Fix build with minizip-ng 4.0.8 2025-01-19 10:30:41 +01:00
Daniel Peukert
f28e134c88
Clean up CRLF line endings 2025-01-12 11:06:04 +01:00
Admiral H. Curtiss
0e5d7d0f2d
Merge pull request #13268 from AdmiralCurtiss/ini-delete-case-sensitive 
Common/IniFile: Fix case sensitivity mismatch in IniFile::Section::Delete()
 2025-01-08 21:42:32 +01:00
OatmealDome
d5dbb0b285 MemArena: Add Darwin implementation 2025-01-08 12:46:31 -05:00
Admiral H. Curtiss
c567248b73
Common/IniFile: Fix case sensitivity mismatch in IniFile::Section::Delete() 
values uses a case insensitive comparison, so erasing the equivalent key in keys_order also must do so.
 2025-01-08 05:30:39 +01:00
Ferdinand Bachmann
b79bdb13c0 Common: Fix compile failure with fmt>=11 2025-01-04 19:13:05 +01:00
mitaclaw
110d32729e Simplify std::find with Common::Contains 
In NandPaths.cpp, the `std::initializer_list<char>` of illegal characters has been turned into a `char[]` (similar to the one in GameList.cpp).

The reverse iteration in ResourcePack.cpp seemed to provide no benefits, and doing without it it seemed to have no ill effects.
 2025-01-01 09:52:03 -08:00
mitaclaw
6f10acea3f Common: Create "Contains.h" Algorithm Header 
The new `Common::Contains` and `Common::ContainsSubrange` function objects mirror C++23's `std::ranges::contains` and `std::ranges::contains_subrange`, respectively.
 2025-01-01 09:52:01 -08:00
JMC47
532a8621da
Merge pull request #13116 from mitaclaw/ranges-modernization-8-trivial-of 
Ranges Algorithms Modernization - Of
 2024-12-26 16:51:53 -05:00
JMC47
1ba8541da9
Merge pull request #13091 from mitaclaw/ranges-modernization-2-returns 
Ranges Algorithms Modernization - Return
 2024-12-20 12:50:19 -05:00