mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-12-23 06:57:08 +00:00
c1922783f8
Fix Frame Advance and FifoPlayer pause/unpause/stop. CPU::EnableStepping is not atomic but is called from multiple threads which races and leaves the system in a random state; also instruction stepping was unstable, m_StepEvent had an almost random value because of the dual purpose it served which could cause races where CPU::Run would SingleStep when it was supposed to be sleeping. FifoPlayer never FinishStateMove()d which was causing it to deadlock. Rather than partially reimplementing CPU::Run, just use CPUCoreBase and then call CPU::Run(). More DRY and less likely to have weird bugs specific to the player (i.e the previous freezing on pause/stop). Refactor PowerPC::state into CPU since it manages the state of the CPU Thread which is controlled by CPU, not PowerPC. This simplifies the architecture somewhat and eliminates races that can be caused by calling PowerPC state functions directly instead of using CPU's (because they bypassed the EnableStepping lock). |
||
|---|---|---|
| .. | ||
| Cheats | ||
| Config | ||
| Debugger | ||
| NetPlay | ||
| resources | ||
| AboutDolphin.cpp | ||
| AboutDolphin.h | ||
| ARCodeAddEdit.cpp | ||
| ARCodeAddEdit.h | ||
| CMakeLists.txt | ||
| ControllerConfigDiag.cpp | ||
| ControllerConfigDiag.h | ||
| DolphinWX.rc | ||
| DolphinWX.vcxproj | ||
| DolphinWX.vcxproj.filters | ||
| DolphinWX.vcxproj.user | ||
| FifoPlayerDlg.cpp | ||
| FifoPlayerDlg.h | ||
| Frame.cpp | ||
| Frame.h | ||
| FrameAui.cpp | ||
| FrameTools.cpp | ||
| GameListCtrl.cpp | ||
| GameListCtrl.h | ||
| Globals.h | ||
| Info.plist.in | ||
| InputConfigDiag.cpp | ||
| InputConfigDiag.h | ||
| InputConfigDiagBitmaps.cpp | ||
| ISOFile.cpp | ||
| ISOFile.h | ||
| ISOProperties.cpp | ||
| ISOProperties.h | ||
| LogConfigWindow.cpp | ||
| LogConfigWindow.h | ||
| LogWindow.cpp | ||
| LogWindow.h | ||
| Main.cpp | ||
| Main.h | ||
| MainNoGUI.cpp | ||
| MemcardManager.cpp | ||
| MemcardManager.h | ||
| PatchAddEdit.cpp | ||
| PatchAddEdit.h | ||
| PostProcessingConfigDiag.cpp | ||
| PostProcessingConfigDiag.h | ||
| resource.h | ||
| SoftwareVideoConfigDialog.cpp | ||
| SoftwareVideoConfigDialog.h | ||
| TASInputDlg.cpp | ||
| TASInputDlg.h | ||
| VideoConfigDiag.cpp | ||
| VideoConfigDiag.h | ||
| WXInputBase.cpp | ||
| WXInputBase.h | ||
| WxUtils.cpp | ||
| WxUtils.h | ||
| X11Utils.cpp | ||
| X11Utils.h | ||