From 0ff9e6fdc3f46693cd23e804583dc4d37585ecdc Mon Sep 17 00:00:00 2001
From: Aarnav Tale <aarnavtale@icloud.com>
Date: Wed, 17 Apr 2024 17:42:44 -0400
Subject: [PATCH] feat: implement better ssr fallbacks

---
 app/routes/_data.acls._index/editor.tsx   | 69 +++++++++++++----------
 app/routes/_data.acls._index/fallback.tsx | 51 +++++++++++++++++
 app/routes/_data.acls._index/route.tsx    |  7 ++-
 tailwind.config.ts                        |  6 +-
 4 files changed, 100 insertions(+), 33 deletions(-)
 create mode 100644 app/routes/_data.acls._index/fallback.tsx

diff --git a/app/routes/_data.acls._index/editor.tsx b/app/routes/_data.acls._index/editor.tsx
index bc779c5..b7b22c7 100644
--- a/app/routes/_data.acls._index/editor.tsx
+++ b/app/routes/_data.acls._index/editor.tsx
@@ -11,6 +11,8 @@ import { toast } from 'react-hot-toast/headless'
 import Button from '~/components/Button'
 import Spinner from '~/components/Spinner'
 
+import Fallback from './fallback'
+
 type EditorProperties = {
 	readonly acl: string;
 	readonly setAcl: (acl: string) => void;
@@ -25,6 +27,8 @@ type EditorProperties = {
 
 export default function Editor({ data, acl, setAcl, mode }: EditorProperties) {
 	const [light, setLight] = useState(false)
+	const [loading, setLoading] = useState(true)
+
 	const fetcher = useFetcher()
 	const aclType = useMemo(() => data.aclType === 'json' ? json() : yaml(), [data.aclType])
 
@@ -35,6 +39,9 @@ export default function Editor({ data, acl, setAcl, mode }: EditorProperties) {
 		theme.addEventListener('change', theme => {
 			setLight(theme.matches)
 		})
+
+		// Prevents the FOUC
+		setLoading(false)
 	}, [])
 
 	return (
@@ -44,38 +51,42 @@ export default function Editor({ data, acl, setAcl, mode }: EditorProperties) {
 				'rounded-b-lg rounded-tr-lg mb-2 overflow-hidden'
 			)}
 			>
-				{mode === 'edit' ? (
-					<CodeMirror
-						value={acl}
-						maxHeight='calc(100vh - 20rem)'
-						theme={light ? githubLight : githubDark}
-						extensions={[aclType]}
-						readOnly={!data.hasAclWrite}
-						onChange={value => {
-							setAcl(value)
-						}}
-					/>
+				{loading ? (
+					<Fallback acl={acl} where='client'/>
 				) : (
-					<div
-						className='overflow-y-scroll'
-						style={{ height: 'calc(100vh - 20rem)' }}
-					>
-						<CodeMirrorMerge
+					mode === 'edit' ? (
+						<CodeMirror
+							value={acl}
+							className='h-editor text-sm'
 							theme={light ? githubLight : githubDark}
-							orientation='a-b'
+							extensions={[aclType]}
+							readOnly={!data.hasAclWrite}
+							onChange={value => {
+								setAcl(value)
+							}}
+						/>
+					) : (
+						<div
+							className='overflow-y-scroll'
+							style={{ height: 'calc(100vh - 20rem)' }}
 						>
-							<CodeMirrorMerge.Original
-								readOnly
-								value={data.currentAcl}
-								extensions={[aclType]}
-							/>
-							<CodeMirrorMerge.Modified
-								readOnly
-								value={acl}
-								extensions={[aclType]}
-							/>
-						</CodeMirrorMerge>
-					</div>
+							<CodeMirrorMerge
+								theme={light ? githubLight : githubDark}
+								orientation='a-b'
+							>
+								<CodeMirrorMerge.Original
+									readOnly
+									value={data.currentAcl}
+									extensions={[aclType]}
+								/>
+								<CodeMirrorMerge.Modified
+									readOnly
+									value={acl}
+									extensions={[aclType]}
+								/>
+							</CodeMirrorMerge>
+						</div>
+					)
 				)}
 			</div>
 
diff --git a/app/routes/_data.acls._index/fallback.tsx b/app/routes/_data.acls._index/fallback.tsx
new file mode 100644
index 0000000..de07fd5
--- /dev/null
+++ b/app/routes/_data.acls._index/fallback.tsx
@@ -0,0 +1,51 @@
+import clsx from 'clsx'
+
+import Button from '~/components/Button'
+
+type FallbackProperties = {
+	readonly acl: string;
+	readonly where: 'client' | 'server';
+}
+
+export default function Fallback({ acl, where }: FallbackProperties) {
+	return (
+		<>
+			<div className={clsx(
+				where === 'server' ? 'mb-2 overflow-hidden rounded-tr-lg rounded-b-lg' : '',
+				where === 'server' ? 'border border-gray-200 dark:border-gray-700' : ''
+			)}
+			>
+				<textarea
+					readOnly
+					className={clsx(
+						'w-full h-editor font-mono resize-none',
+						'text-sm text-gray-600 dark:text-gray-300',
+						'pl-10 pt-1 leading-snug'
+					)}
+					value={acl}
+				/>
+			</div>
+			{where === 'server' ? (
+				<>
+					<Button
+						disabled
+						variant='emphasized'
+						className='text-sm w-fit mr-2'
+					>
+						Save
+					</Button>
+					<Button
+						disabled
+						variant='emphasized'
+						className={clsx(
+							'text-sm w-fit bg-gray-100 dark:bg-transparent',
+							'border border-gray-200 dark:border-gray-700'
+						)}
+					>
+						Discard Changes
+					</Button>
+				</>
+			) : undefined}
+		</>
+	)
+}
diff --git a/app/routes/_data.acls._index/route.tsx b/app/routes/_data.acls._index/route.tsx
index 26cc6e4..94c5114 100644
--- a/app/routes/_data.acls._index/route.tsx
+++ b/app/routes/_data.acls._index/route.tsx
@@ -13,6 +13,7 @@ import { sighupHeadscale } from '~/utils/docker'
 import { getSession } from '~/utils/sessions'
 
 import Editor from './editor'
+import Fallback from './fallback'
 
 export async function loader() {
 	const context = await getContext()
@@ -146,14 +147,14 @@ export default function Page() {
 				</Tab.List>
 				<Tab.Panels>
 					<Tab.Panel>
-						<ClientOnly>
+						<ClientOnly fallback={<Fallback acl={acl} where='server'/>}>
 							{() => (
 								<Editor data={data} acl={acl} setAcl={setAcl} mode='edit'/>
 							)}
 						</ClientOnly>
 					</Tab.Panel>
 					<Tab.Panel>
-						<ClientOnly>
+						<ClientOnly fallback={<Fallback acl={acl} where='server'/>}>
 							{() => (
 								<Editor data={data} acl={acl} setAcl={setAcl} mode='diff'/>
 							)}
@@ -170,7 +171,7 @@ export default function Page() {
 							<CubeTransparentIcon className='w-24 h-24 text-gray-300 dark:text-gray-500'/>
 							<p className='w-1/2 text-center mt-4'>
 								The Preview rules is very much still a work in progress.
-								It's a bit complicated to implement right now but hopefully it will be available soon.
+								It is a bit complicated to implement right now but hopefully it will be available soon.
 							</p>
 						</div>
 					</Tab.Panel>
diff --git a/tailwind.config.ts b/tailwind.config.ts
index 8233994..cca4782 100644
--- a/tailwind.config.ts
+++ b/tailwind.config.ts
@@ -3,7 +3,11 @@ import type { Config } from 'tailwindcss'
 export default {
 	content: ['./app/**/*.{js,jsx,ts,tsx}'],
 	theme: {
-		extend: {}
+		extend: {
+			height: {
+				editor: 'calc(100vh - 20rem)'
+			}
+		}
 	},
 	plugins: []
 } satisfies Config