dahjah/pcsx2
1
0
Fork 0
mirror of https://github.com/PCSX2/pcsx2.git synced 2025-12-16 04:08:48 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

[ci skip] DumpRunner: Fix race condition when creating files/folders, set process priority to below normal. (#13203)

Browse Source 
Fixes race condition when running in parallel multiple threads when creating dump folder/files.
Makes the process priority below normal so the system remains more usable even with more threads.
This commit is contained in:
lightningterror 2025-08-31 00:30:03 +02:00 committed by GitHub
parent 7e4bc6ba22
commit 26fcbc712e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
pcsx2-gsrunner/test_run_dumps.py
View File

@ -6,6 +6,7 @@ import subprocess
import multiprocessing import multiprocessing
from pathlib import Path from pathlib import Path
from functools import partial from functools import partial
import platform
def get_gs_name(path): def get_gs_name(path):
lpath = path.lower() lpath = path.lower()
@ -22,9 +23,11 @@ def run_regression_test(runner, dumpdir, renderer, upscale, renderhacks, paralle
gsname = get_gs_name(gspath) gsname = get_gs_name(gspath)
real_dumpdir = os.path.join(dumpdir, gsname).strip() real_dumpdir = os.path.join(dumpdir, gsname).strip()
if not os.path.exists(real_dumpdir): # Safe creation and skip if folder exists
os.mkdir(real_dumpdir) try:
else: os.makedirs(real_dumpdir)
except FileExistsError:
# Folder already exists → skip this game
return return
if renderer is not None: if renderer is not None:
@ -54,19 +57,31 @@ def run_regression_test(runner, dumpdir, renderer, upscale, renderhacks, paralle
environ = os.environ.copy() environ = os.environ.copy()
environ["PCSX2_NOCONSOLE"] = "1" environ["PCSX2_NOCONSOLE"] = "1"
creationflags = 0
# Set low priority by default
if platform.system() == "Windows":
creationflags = 0x00004000 # BELOW_NORMAL_PRIORITY_CLASS
elif platform.system() in ["Linux", "Darwin"]:
try:
os.nice(10) # lower priority
except OSError:
pass
args.append("--") args.append("--")
args.append(gspath) args.append(gspath)
#print("Running '%s'" % (" ".join(args))) #print("Running '%s'" % (" ".join(args)))
subprocess.run(args, env=environ, stdin=subprocess.DEVNULL, stderr=subprocess.DEVNULL, stdout=subprocess.DEVNULL) subprocess.run(args, env=environ, stdin=subprocess.DEVNULL, stderr=subprocess.DEVNULL, stdout=subprocess.DEVNULL, creationflags=creationflags)
def run_regression_tests(runner, gsdir, dumpdir, renderer, upscale, renderhacks, parallel=1): def run_regression_tests(runner, gsdir, dumpdir, renderer, upscale, renderhacks, parallel=1):
paths = glob.glob(gsdir + "/*.*", recursive=True) paths = glob.glob(gsdir + "/*.*", recursive=True)
gamepaths = list(filter(lambda x: get_gs_name(x) is not None, paths)) gamepaths = list(filter(lambda x: get_gs_name(x) is not None, paths))
if not os.path.isdir(dumpdir): try:
os.mkdir(dumpdir) os.makedirs(dumpdir)
except FileExistsError:
pass
print("Found %u GS dumps" % len(gamepaths)) print("Found %u GS dumps" % len(gamepaths))
@ -95,7 +110,7 @@ if __name__ == "__main__":
parser.add_argument("-renderer", action="store", required=False, help="Renderer to use") parser.add_argument("-renderer", action="store", required=False, help="Renderer to use")
parser.add_argument("-upscale", action="store", type=float, default=1, help="Upscaling multiplier to use") parser.add_argument("-upscale", action="store", type=float, default=1, help="Upscaling multiplier to use")
parser.add_argument("-renderhacks", action="store", required=False, help="Enable HW Rendering hacks") parser.add_argument("-renderhacks", action="store", required=False, help="Enable HW Rendering hacks")
parser.add_argument("-parallel", action="store", type=int, default=1, help="Number of proceeses to run") parser.add_argument("-parallel", action="store", type=int, default=1, help="Number of processes to run")
args = parser.parse_args() args = parser.parse_args()